Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache metadata and audio keys #22

Closed
sashahilton00 opened this issue Jan 29, 2018 · 3 comments
Closed

Cache metadata and audio keys #22

sashahilton00 opened this issue Jan 29, 2018 · 3 comments

Comments

@sashahilton00
Copy link
Member

Issue by plietar
Wednesday Dec 30, 2015 at 12:03 GMT
Originally opened as plietar/librespot#19


Metadata and keys should be stored in cache as well, in something like an sqlite database.

@sashahilton00
Copy link
Member Author

Comment by plietar
Wednesday Mar 16, 2016 at 04:21 GMT


Audio keys are now cached (85903a0).
Metadata isn't yet.

@sashahilton00
Copy link
Member Author

@plietar given that it's a connect implementation (always online), and metadata is fairly lightweight, is it worth the trouble?

@sashahilton00
Copy link
Member Author

Closing this as a non-issue. librespot is primarily a connect client in it's current form, thus metadata caching is semi pointless when it's always online. In the event that it is being used as a library by another program, each program's requirements will be different, and thus the optimal caching strategy will likely differ between projects, and should be left up to them to implement. What's important is that librespot provides the interface for metadata retrieval. Closing, can be reopened if there is disagreement with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant