Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation #161

Closed
Taiki-San opened this issue Nov 7, 2015 · 4 comments
Closed

Incorrect documentation #161

Taiki-San opened this issue Nov 7, 2015 · 4 comments
Assignees

Comments

@Taiki-San
Copy link

The documentation of EVP_PKEY_decrypt and EVP_PKEY_encrypt is incorrect, probably not updated when the API changed.
The exemple for two API show the use of RSA_OAEP_PADDING as an argument of EVP_PKEY_CTX_set_rsa_padding. However, this isn't defined in the last version of either OpenSSL or LibreSSL.
The correct constant is probably RSA_PKCS1_OAEP_PADDING.
However, I can't submit a formal pull request because the man/*.3 files aren't available in the tree on github.
The two affected files in the last release are

man/EVP_PKEY_decrypt.3
man/EVP_PKEY_encrypt.3
@busterb
Copy link
Contributor

busterb commented Dec 7, 2015

For documentation updates, I would suggest either PR to https://github.com/libressl-portable/openbsd , or email to tech@openbsd.org

@busterb busterb added the ready label Jan 5, 2016
@busterb busterb self-assigned this Jan 5, 2016
@busterb
Copy link
Contributor

busterb commented Mar 12, 2016

I submitted a patch to fix this to tech@openbsd.org

busterb pushed a commit to libressl/openbsd that referenced this issue Mar 13, 2016
Noted here, libressl/portable#161, we
document a non-existent constant in the examples for
EVP_PKEY_CTX_set_rsa_padding.

ok deraadt@
@busterb
Copy link
Contributor

busterb commented Mar 13, 2016

Fixed here: libressl/openbsd@ebccdf2

Thanks @Taiki-San

@busterb busterb closed this as completed Mar 13, 2016
@busterb busterb removed the ready label Mar 13, 2016
@Taiki-San
Copy link
Author

No problem, thanks for fixing the issue!

bluerise pushed a commit to bitrig/bitrig that referenced this issue May 3, 2016
Noted here, libressl/portable#161, we
document a non-existent constant in the examples for
EVP_PKEY_CTX_set_rsa_padding.

ok deraadt@
stmuk pushed a commit to stmuk/bitrig that referenced this issue May 7, 2016
Noted here, libressl/portable#161, we
document a non-existent constant in the examples for
EVP_PKEY_CTX_set_rsa_padding.

ok deraadt@
rurban pushed a commit to rurban/openssl that referenced this issue Jun 1, 2016
Noted here, libressl/portable#161, we
document a non-existent constant in the examples for
EVP_PKEY_CTX_set_rsa_padding.

ok deraadt@
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants