Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLSEXT_TYPE_application_layer_protocol_negotiation defined without implementation #50

Closed
johansglock opened this issue Dec 17, 2014 · 1 comment

Comments

@johansglock
Copy link

In the following commit TLSEXT_TYPE_application_layer_protocol_negotiation was added:
libressl/openbsd@9439a6a

This is included in LibreSSL 2.1.2 release without the ALPN implementation. Nginx uses this define to determine wether it should try to enable ALPN support as follows:

#ifdef TLSEXT_TYPE_application_layer_protocol_negotiation
    SSL_CTX_set_alpn_select_cb(conf->ssl.ctx, ngx_http_ssl_alpn_select, NULL);                                                                                                 
#endif

#ifdef TLSEXT_TYPE_next_proto_neg
    SSL_CTX_set_next_protos_advertised_cb(conf->ssl.ctx,
                                          ngx_http_ssl_npn_advertised, NULL);
#endif

Which breaks the build of course. In light of keeping keeping compatibility with software build for OpenSSL I would personally like to see that either this define is removed from the current release or perhaps do another minor update (as I saw that the ALPN implementation is being worked on) with the ALPN API available (if this is compatible).

What's the stand on this aspect from the developer team?

@busterb
Copy link
Contributor

busterb commented Dec 17, 2014

The rest of ALPN support was merged last week. We just need to roll a new release. Will probably do that in the next week or so. You can test in the mean time against git mirror HEAD if you like.

@busterb busterb closed this as completed Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants