error: initializer overrides prior initialization of this subobject

[yurivict]

clang fails to build 4.4:

/usr/ports/net/libreswan/work/libreswan-4.4/lib/libswan/ike_alg_aes.c:61:26: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
        .encrypt_sadb_ealg_id = SADB_X_EALG_AES,
                                ^~~~~~~~~~~~~~~

[yurivict]

There's double initialization of the same field when both preprocessor variables are defined:

#ifdef SADB_X_EALG_AESCBC
        .encrypt_sadb_ealg_id = SADB_X_EALG_AESCBC,
#endif
#ifdef SADB_X_EALG_AES
        .encrypt_sadb_ealg_id = SADB_X_EALG_AES,
#endif

[cagney]

What does the FreeBSD header define?

[yurivict]

$ grep -r SADB_X_EALG_AESCBC /usr/include/
/usr/include/net/pfkeyv2.h:#define	SADB_X_EALG_AESCBC	12

$ grep -r SADB_X_EALG_AES /usr/include/
/usr/include/net/pfkeyv2.h:#define SADB_X_EALG_AES		12
/usr/include/net/pfkeyv2.h:#define	SADB_X_EALG_AESCBC	12
/usr/include/net/pfkeyv2.h:#define SADB_X_EALG_AESCTR	13
/usr/include/net/pfkeyv2.h:#define SADB_X_EALG_AESGCM8	18	/* RFC4106 */
/usr/include/net/pfkeyv2.h:#define SADB_X_EALG_AESGCM12	19
/usr/include/net/pfkeyv2.h:#define SADB_X_EALG_AESGCM16	20
/usr/include/net/pfkeyv2.h:#define SADB_X_EALG_AESGMAC	23	/* RFC4543 + Errata1821 */
/usr/include/netipsec/keydb.h:			((_sav)->alg_enc == SADB_X_EALG_AESGCM8 ||	\
/usr/include/netipsec/keydb.h:			(_sav)->alg_enc == SADB_X_EALG_AESGCM12 ||	\
/usr/include/netipsec/keydb.h:			(_sav)->alg_enc == SADB_X_EALG_AESGCM16)
/usr/include/netipsec/keydb.h:#define	SAV_ISCTR(_sav) ((_sav)->alg_enc == SADB_X_EALG_AESCTR)

[yurivict]

https://cgit.freebsd.org/src/tree/sys/net/pfkeyv2.h

[cagney]

/usr/include/net/pfkeyv2.h:#define SADB_X_EALG_AES 12
/usr/include/net/pfkeyv2.h:#define SADB_X_EALG_AESCBC 12

dumb

[yurivict]

Should all these values be different?

#define SADB_X_EALG_RIJNDAELCBC	12
#define SADB_X_EALG_AES		12
#define	SADB_X_EALG_AESCBC	12

[cagney]

No. They're referring to the same algorithm.

[cagney]

For reference, it was only recently added (2020):
https://cgit.freebsd.org/src/commit/sys/net/pfkeyv2.h?id=00a4311adc197c3518f5d60c69e00c4e80d065fd

Refer to AES-CBC as "aes-cbc" rather than "rijndael-cbc" for IPsec.
At this point, AES is the more common name for Rijndael128. setkey(8)
will still accept the old name, and old constants remain for
compatiblity.