Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge worker inside api #1972

Open
jooola opened this issue Jul 19, 2022 · 1 comment
Open

Merge worker inside api #1972

jooola opened this issue Jul 19, 2022 · 1 comment
Assignees
Labels
is: feature-request status: pinned This issue or pull request won't stale

Comments

@jooola
Copy link
Contributor

jooola commented Jul 19, 2022

To go one step closer to the new architecture design, we need to merge the celery worker inside the API.

This should happen for 3.1.x or 4.0.0 depending if we find a way that doesn't break anything. I think this should be doable for 3.1.x, but might require some user intervention for some cleanup (clean old libretime-celery package and service).

Here is a roadmap that describe how we can accomplish that.

  • Move the celery worker inside the django api
  • Rewrite the podcast download task to use the django ORM
    • download and save data directly to the DB
  • Rewrite how legacy starts a podcast download task
    • by sending a message to the worker without the jooola/celery-php library
  • Rewrite how legacy awaits the result of the podcasts download
    • query the DB until the new data landed ?
  • Remove the jooola/celery-php library from legacy
  • Upgrade celery to v5 (was blocked by the jooola/celery-php library)

This should unlock some issues / pull requests:

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This issue has been automatically marked as stale because it has not had activity in the last 5 months. It will be closed if no activity occurs in the next month.
Please chat to us on the forum or ask for help on our chat if you have any questions or need further support with getting this issue resolved.
You may also label an issue as pinned if you would like to make sure that it does not get closed by this bot.

@github-actions github-actions bot added the status: stalled This issue or pull request is stalled label Mar 4, 2023
@jooola jooola added status: pinned This issue or pull request won't stale and removed status: stalled This issue or pull request is stalled labels Mar 4, 2023
@jooola jooola removed this from the 3.1.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: feature-request status: pinned This issue or pull request won't stale
Projects
None yet
Development

No branches or pull requests

1 participant