Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playout): missing live show events #2087

Merged
merged 1 commit into from Sep 6, 2022

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Sep 4, 2022

Fix #2084

@jooola jooola changed the title feat(playout): generate show live events feat(playout): generate live show events Sep 4, 2022
@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Merging #2087 (fd01222) into main (be14fb8) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
+ Coverage   58.65%   58.84%   +0.18%     
==========================================
  Files         184      184              
  Lines        4574     4592      +18     
==========================================
+ Hits         2683     2702      +19     
+ Misses       1891     1890       -1     
Flag Coverage Δ
api 93.88% <100.00%> (+0.01%) ⬆️
playout 20.24% <100.00%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/libretime_api/schedule/serializers/show.py 100.00% <ø> (ø)
api/libretime_api/schedule/models/show.py 95.74% <100.00%> (+0.14%) ⬆️
playout/libretime_playout/player/schedule.py 100.00% <100.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jooola jooola force-pushed the schedule_show_kicks branch 3 times, most recently from 1925b1d to 52f6ffc Compare September 4, 2022 15:52
@jooola
Copy link
Contributor Author

jooola commented Sep 4, 2022

I am a bit lazy and I will wait for #1986 to have access to the input_fade_transition StreamPreferences. It is required to generate the live show events.

@jooola jooola force-pushed the schedule_show_kicks branch 3 times, most recently from a762e8c to dd273c9 Compare September 5, 2022 14:53
@jooola
Copy link
Contributor Author

jooola commented Sep 5, 2022

Depends on #2088 and #1986

@jooola jooola force-pushed the schedule_show_kicks branch 2 times, most recently from 442eb2f to a3d8259 Compare September 6, 2022 11:35
@jooola jooola changed the title feat(playout): generate live show events fix(playout): generate live show events Sep 6, 2022
@jooola jooola changed the title fix(playout): generate live show events fix(playout): missing live show events Sep 6, 2022
@jooola jooola marked this pull request as ready for review September 6, 2022 12:01
@jooola
Copy link
Contributor Author

jooola commented Sep 6, 2022

Tested on bullseye. Ready to be reviewed/merged.

@paddatrapper paddatrapper merged commit ef1de34 into libretime:main Sep 6, 2022
@jooola jooola deleted the schedule_show_kicks branch September 6, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing input stream kick events from playout schedule generation
2 participants