Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): remove db allowed_cors_origins preference #2095

Merged
merged 1 commit into from Oct 11, 2022

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Sep 6, 2022

  • Remove after deprecation in eb8e7b3

@jooola jooola added this to the 3.1.0 milestone Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #2095 (f415a1f) into main (e54c8d2) will decrease coverage by 1.08%.
The diff coverage is 100.00%.

❗ Current head f415a1f differs from pull request most recent head 1d0148f. Consider uploading reports for the commit 1d0148f to get more accurate results

@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
- Coverage   60.75%   59.67%   -1.09%     
==========================================
  Files         180      187       +7     
  Lines        4355     4692     +337     
==========================================
+ Hits         2646     2800     +154     
- Misses       1709     1892     +183     
Flag Coverage Δ
api 94.30% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/legacy/migrations/0040_remove_cors_preference.py 100.00% <100.00%> (ø)
api/libretime_api/legacy/migrations/_version.py 93.75% <0.00%> (-0.99%) ⬇️
shared/libretime_shared/config/_models.py 95.68% <0.00%> (-0.37%) ⬇️
shared/libretime_shared/datetime.py 100.00% <0.00%> (ø)
playout/libretime_playout/recorder.py 0.00% <0.00%> (ø)
playout/libretime_playout/player/file.py 0.00% <0.00%> (ø)
playout/libretime_playout/player/push.py 0.00% <0.00%> (ø)
playout/libretime_playout/player/fetch.py 0.00% <0.00%> (ø)
playout/libretime_playout/player/queue.py 0.00% <0.00%> (ø)
playout/libretime_playout/message_handler.py 0.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jooola jooola force-pushed the db_cors_pref_removal branch 2 times, most recently from 22996db to f415a1f Compare September 12, 2022 12:28
@jooola jooola force-pushed the db_cors_pref_removal branch 2 times, most recently from 2469d30 to 8c469bb Compare September 15, 2022 21:31
@jooola jooola force-pushed the db_cors_pref_removal branch 2 times, most recently from 5fd3716 to d44303b Compare October 10, 2022 20:11
@jooola jooola marked this pull request as ready for review October 11, 2022 09:43
@paddatrapper paddatrapper merged commit cff98f2 into libretime:main Oct 11, 2022
@jooola jooola deleted the db_cors_pref_removal branch October 11, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants