Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): do not delete audio file when removing artwork #2395

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

togir2
Copy link
Contributor

@togir2 togir2 commented Feb 24, 2023

Description

While removing a custom artwork the audio file is also deleted.

This is a new feature:

No

I have updated the documentation to reflect these changes:
No

Testing Notes

This bug does only appear with custom cover images.
The default ones are not affected because they are in a different folder than the custom ones

  1. Edit track
  2. Add custom cover image and save
  3. remove cover image => audio_file deleted

After the patch:

  1. Edit track
  2. Add custom cover image and save
  3. remove cover image => audio_file is not deleted

@togir2 togir2 changed the title Fix: Do not delete audio file when removing artwork fix: Do not delete audio file when removing artwork Feb 24, 2023
@togir2 togir2 changed the title fix: Do not delete audio file when removing artwork fix: do not delete audio file when removing artwork Feb 24, 2023
@togir2 togir2 force-pushed the audiofile-lost-on-artwork-removal branch from 4e6d783 to 2d7de01 Compare February 24, 2023 09:21
@jooola
Copy link
Contributor

jooola commented Feb 24, 2023

Ooh, nice catch!

Now that I see this, the glob really scares me. I think we should be more explicit to what we delete here.

I've pushed an extra commit to replace the glob and fixed the CI checks.

Thanks for the patch!

@jooola jooola changed the title fix: do not delete audio file when removing artwork fix(legacy): do not delete audio file when removing artwork Feb 24, 2023
@jooola jooola merged commit a2aca7d into libretime:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants