feat: use secret_key config field instead of api_key #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
secret_key
branch
3 times, most recently
from
1bf06f9
to
e98a8b5
Compare
Codecov Report
@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
+ Coverage 61.68% 61.74% +0.06%
==========================================
Files 149 151 +2
Lines 4155 4167 +12
==========================================
+ Hits 2563 2573 +10
- Misses 1592 1594 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jooola
force-pushed
the
secret_key
branch
3 times, most recently
from
35af910
to
c20b1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2426
This adds a warning about a future required configuration field, that will fallback to the previous behavior (use the
general.api_keyas secret_key) in case of a missing value. We must make the field required on the next major version bump, we will keep track of this in #2426.New LibreTime setup will have the secret_key field filled during the install process.