Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add cors headers middleware #2479

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Mar 23, 2023

Sets the base for CORS request on the API, this will probably need more tweaking in the config later on.

@jooola jooola changed the title feat: add cors config to api feat(api): add cors config middleware Mar 23, 2023
@jooola jooola changed the title feat(api): add cors config middleware feat(api): add cors headers middleware Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2479 (682fe0a) into main (d2f93f7) will increase coverage by 10.74%.
The diff coverage is 48.36%.

@@             Coverage Diff             @@
##             main    #2479       +/-   ##
===========================================
+ Coverage   58.60%   69.34%   +10.74%     
===========================================
  Files         146      149        +3     
  Lines        4343     4006      -337     
===========================================
+ Hits         2545     2778      +233     
+ Misses       1798     1228      -570     
Flag Coverage Δ
analyzer 46.91% <27.27%> (-0.43%) ⬇️
api 93.68% <72.22%> (-0.29%) ⬇️
api-client 64.40% <55.81%> (+23.41%) ⬆️
playout 46.43% <44.09%> (+20.63%) ⬆️
shared 88.39% <88.88%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
analyzer/libretime_analyzer/main.py 0.00% <0.00%> (ø)
api/libretime_api/core/models/preference.py 100.00% <ø> (ø)
playout/libretime_playout/liquidsoap/main.py 0.00% <0.00%> (ø)
playout/libretime_playout/main.py 0.00% <0.00%> (ø)
playout/libretime_playout/notify/main.py 0.00% <0.00%> (ø)
playout/libretime_playout/player/file.py 27.08% <7.69%> (+27.08%) ⬆️
playout/libretime_playout/player/liquidsoap.py 22.65% <25.00%> (+22.65%) ⬆️
playout/libretime_playout/player/push.py 40.62% <33.33%> (+40.62%) ⬆️
...out/libretime_playout/liquidsoap/client/_client.py 32.94% <37.50%> (-0.80%) ⬇️
playout/libretime_playout/message_handler.py 42.00% <42.85%> (+42.00%) ⬆️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paddatrapper paddatrapper merged commit 7962c0a into libretime:main Mar 23, 2023
@jooola jooola deleted the api_cors branch March 23, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants