Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playout): remove unused ecasound package #2496

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Apr 3, 2023

The recorder has been removed, so the ecasound package isn't used anymore.

The recorder has been removed, so the ecasound package isn't used anymore.
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #2496 (7b36533) into main (903a643) will increase coverage by 8.08%.
The diff coverage is 49.50%.

@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   61.68%   69.77%   +8.08%     
==========================================
  Files         149      149              
  Lines        4155     4006     -149     
==========================================
+ Hits         2563     2795     +232     
+ Misses       1592     1211     -381     
Flag Coverage Δ
playout 47.66% <46.22%> (+17.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/libretime_api/core/models/preference.py 100.00% <ø> (ø)
api/libretime_api/settings/_internal.py 86.20% <ø> (ø)
playout/libretime_playout/liquidsoap/entrypoint.py 100.00% <ø> (ø)
playout/libretime_playout/main.py 0.00% <0.00%> (ø)
playout/libretime_playout/message_handler.py 42.00% <ø> (+42.00%) ⬆️
playout/libretime_playout/notify/main.py 0.00% <0.00%> (ø)
playout/libretime_playout/player/file.py 27.08% <5.26%> (+27.08%) ⬆️
playout/libretime_playout/player/liquidsoap.py 22.65% <14.89%> (+22.65%) ⬆️
playout/libretime_playout/player/fetch.py 27.88% <18.18%> (+27.88%) ⬆️
...out/libretime_playout/player/liquidsoap_gateway.py 45.05% <46.15%> (+1.43%) ⬆️
... and 14 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paddatrapper paddatrapper merged commit 6b6e895 into libretime:main Apr 3, 2023
@jooola jooola deleted the playout_remove_ecasound branch April 3, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants