Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(legacy): move session store to database #2523

Merged
merged 1 commit into from
May 30, 2023
Merged

feat(legacy): move session store to database #2523

merged 1 commit into from
May 30, 2023

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Apr 24, 2023

Related to #1788

@codecov
Copy link

codecov bot commented Apr 24, 2023 •
edited
Loading

Codecov Report

Merging #2523 (70e702e) into main (be282fa) will not change coverage.
The diff coverage is n/a.

❗ Current head 70e702e differs from pull request most recent head fadc838. Consider uploading reports for the commit fadc838 to get more accurate results

@@           Coverage Diff           @@
##             main    #2523   +/-   ##
=======================================
  Coverage   69.96%   69.96%           
=======================================
  Files         147      147           
  Lines        3972     3972           
=======================================
  Hits         2779     2779           
  Misses       1193     1193
Flag Coverage Δ
api 93.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jooola jooola force-pushed the legacy_database_session branch 3 times, most recently from ee6bb4b to 50c5228 Compare May 11, 2023 08:16
@jooola jooola mentioned this pull request May 11, 2023
Open
@jooola jooola force-pushed the legacy_database_session branch 5 times, most recently from 5ccea5b to 70e702e Compare May 30, 2023 12:21
@jooola jooola requested a review from paddatrapper May 30, 2023 14:39
@jooola jooola mentioned this pull request May 30, 2023
Draft
@jooola
Copy link
Contributor Author

jooola commented May 30, 2023

This PR is a preparation work for #2572

paddatrapper
paddatrapper approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@paddatrapper paddatrapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't really understand PHP though, so I won't be able to give a deep review of the actual code

@jooola jooola marked this pull request as ready for review May 30, 2023 20:24
@jooola jooola merged commit 001466f into libretime:main May 30, 2023
21 checks passed
@jooola jooola deleted the legacy_database_session branch May 30, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddatrapper paddatrapper paddatrapper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jooola @paddatrapper