Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mobile devices stream config field #2744

Merged

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Oct 13, 2023

Description

Allow to configure streams to be used for mobile devices. The field was removed while moving to the new config file, the feature should be working ™️ .

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5a7e4db) 70.15% compared to head (4f2b5bc) 70.16%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2744      +/-   ##
==========================================
+ Coverage   70.15%   70.16%   +0.01%     
==========================================
  Files         147      147              
  Lines        3997     3999       +2     
==========================================
+ Hits         2804     2806       +2     
  Misses       1193     1193              
Flag Coverage Δ
analyzer 46.91% <ø> (ø)
api 93.79% <ø> (ø)
api-client 64.40% <ø> (ø)
playout 47.67% <ø> (ø)
shared 88.48% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
shared/libretime_shared/config/_models.py 96.17% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola
Copy link
Contributor Author

jooola commented Oct 13, 2023

Some screenshots:
image
image

@paddatrapper paddatrapper merged commit b2e512c into libretime:main Oct 14, 2023
37 checks passed
@jooola jooola deleted the reenable-mobile-stream-selection branch December 29, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants