Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose retro_set_environment in RetroCore? #12

Closed
InquisitiveCoder opened this issue Nov 24, 2022 · 0 comments · Fixed by #14
Closed

Expose retro_set_environment in RetroCore? #12

InquisitiveCoder opened this issue Nov 24, 2022 · 0 comments · Fixed by #14
Milestone

Comments

@InquisitiveCoder
Copy link
Contributor

Certain uses of the environment callback can only be done during retro_set_environment; however, users of the crate lack the ability to execute code during that callback. Out of several such options, the libretro_core! macro only handles SET_SUPPORT_NO_GAME. However, this approach requires updating the macro and trait every time a new option is added to the environment callback that can only be handled from retro_set_environment. A more flexible approach that'd support all current and future options would be to add a set_environment() function to RetroCore which the macro then calls.

@ghost ghost linked a pull request Nov 27, 2022 that will close this issue
@ghost ghost closed this as completed in #14 Nov 27, 2022
@ghost ghost added this to the 0.2.0 milestone Nov 27, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant