Move core initialization to load_game for better ergonomics #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addesses Issue #3: Move RetroCore instantiation to load_game for better ergonomics. Below is a summary of the changes:
retro_init
andretro_deinit
are now no-ops.RetroCore::init
.RetroLoadGameResult
contains an additional field for theRetroCore
instance.RetroCore::load_game
is now a function.RetroInstance::on_init
andon_deinit
. The code has been moved toon_load_game
andon_unload_game
respectively.With these changes, users of the crate return a fully initialized instance from
RetroCore::load_game
rather than return a partially initialized instance frominit
and updating it inload_game
.Since this isn't a backwards-compatible change, I've updated the minor digit of the version number.