Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't call RetroRuntime::is_joypad_button_pressed #6

Closed
InquisitiveCoder opened this issue Nov 23, 2022 · 1 comment · Fixed by #10
Closed

Can't call RetroRuntime::is_joypad_button_pressed #6

InquisitiveCoder opened this issue Nov 23, 2022 · 1 comment · Fixed by #10
Labels
good first issue Good for newcomers
Milestone
0.2.0

Comments

@InquisitiveCoder
Copy link
Contributor

Commit 9b4c3f0 ("various cleanups and improvements") changed the first argument of RetroRuntime::is_joypad_button_pressed from u32 to RetroDevicePort, but RetroDevicePort doesn't have a public constructor.
@ghost
Copy link

ghost commented Nov 24, 2022

Emulators don't need to query for buttons though.. right? 😅

@ghost ghost added the good first issue Good for newcomers label Nov 24, 2022
@ghost ghost added this to the 0.2.0 milestone Nov 24, 2022
@InquisitiveCoder InquisitiveCoder mentioned this issue Nov 24, 2022
Merged
@ghost ghost linked a pull request Nov 24, 2022 that will close this issue
Add public constructor for RetroDevicePort. #10
Merged
@ghost ghost closed this as completed in #10 Nov 30, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Add public constructor for RetroDevicePort. InquisitiveCoder/libretro-rs
1 participant
@InquisitiveCoder