Fix padding in navbar and add gravatar support #70
Conversation
oBlissing
commented
Oct 23, 2017
oBlissing
commented
- Fix navbar having some spacing between menu-items and outer container
- Add a user gravatar if available
xl_auth/utils.py
Outdated
| def get_gravatar_url(user_email, size): | ||
| """Get gravatar url from user email.""" | ||
| clean_email = str(user_email).lower().encode() | ||
| hash = hashlib.md5(clean_email) |
There was a problem hiding this comment.
Shadows built-in name hash. And I think this should be a method on the User model instead of a stand-alone utility function. That way you can always call current_user.get_gravatar_url(64) without any fuzz.
Something like this:
def get_gravatar_url(self, size=32):
"""Get Gravatar URL."""
hashed_email = hashlib.md5(str(self.email).lower()).hexdigest()
return 'https://www.gravatar.com/avatar/{}?d=mm&s={}'.format(hashed_email, size)
|
Should be able to merge this now |
| @@ -556,3 +555,6 @@ msgstr "Användarinställningar uppdaterade för \"%(username)s\"." | |||
| msgid "Thank you for changing password for \"%(username)s\"." | |||
| msgstr "Lösenord för \"%(username)s\" har ändrats." | |||
|
|
|||
| #~ msgid "Logged in as %(user)s" | |||
There was a problem hiding this comment.
This #~ ... marks lines that are no longer used and can be removed. So lets remove them!
| </a> | ||
| </p> | ||
| <a class="navbar-link" href="{{ url_for('user.profile') }}"> | ||
| <img class="navbar-user-gravatar" src="{{ current_user.get_gravatar_url(32) }}" /> |
There was a problem hiding this comment.
"32" is redundant, since you set that as the default in the get_gravatar_url method. Feel free to keep it though, if you think it adds value. Just mentioning since you're new to Python! 😸
assets/css/style.less
Outdated
| } | ||
| } | ||
| .navbar-user-gravatar { |
There was a problem hiding this comment.
@oBlissing Please do the PyCharm + ⌥⌘L and commit again!
Also, I don't think the previous line-40 brace was a "stray" one. The entire .logotype block is!
|
@oBlissing I added a simple unittest to your pull request in 94ca74b, hope you don't mind! Merge at will. |
