Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake transition changed the soname to librsync.so.1 #48

Closed
foutrelis opened this issue Nov 23, 2015 · 2 comments

Comments

@foutrelis
Copy link

commented Nov 23, 2015

Assuming the 1.0.1 release is binary compatible with 1.0.0, it needs to retain the "librsync.so.2" soname and under no circumstances use "librsync.so.1" (which was the soname back in the librsync 0.9.7 days).

I believe a new release must be made with the above correction; 1.0.1 cannot be packaged by Linux distros.

@Salamek

This comment has been minimized.

Copy link
Member

commented Nov 23, 2015

In that case we need to change LIBRSYNC_MAJOR_VERSION to 2 (so version will be 2.0.1 or 2.0.0 ) cos this in CMakeLists.txt:

set_target_properties(rsync PROPERTIES VERSION ${LIBRSYNC_VERSION} SOVERSION ${LIBRSYNC_MAJOR_VERSION})

or just do

set_target_properties(rsync PROPERTIES VERSION ${LIBRSYNC_VERSION} SOVERSION 2)

but that is ugly... i think soversion should match major version... and cos there is librsync.so.2 "out there" binary compatible with 1.0.1... moving LIBRSYNC_MAJOR_VERSION to 2 is only ~clean solution

@sourcefrog ?

@sourcefrog

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2015

Hi, thanks for flagging this regression.

In previous versions of librsync I followed the advice in the libtool manual to allow the software release version and the library version to be different. See https://github.com/librsync/librsync/blob/e2d3bdf88bb792b4c022afddb2e8462e519d0bc2/libversions.txt.

However this is pretty crazy and confusing.

So I plan to fix this by just bumping the library version up to 2.0.0.

@sourcefrog sourcefrog added the bug label Nov 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.