Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review some existing unit tests #120

Closed
ManaSugi opened this issue Feb 27, 2022 · 1 comment
Closed

Review some existing unit tests #120

ManaSugi opened this issue Feb 27, 2022 · 1 comment
Assignees
@ManaSugi
Labels
test Improvements to tests
Milestone
0.3.0

Comments

@ManaSugi
Copy link
Member

Some current unit tests such as test_get_syscall_name_from_arch() just output a message using println!.
We need to fix the tests properly using assert macro.

Ref. #119 (comment)
@ManaSugi ManaSugi added the test Improvements to tests label Feb 27, 2022
@ManaSugi ManaSugi added this to the 0.3.0 milestone Feb 27, 2022
@ManaSugi ManaSugi self-assigned this Mar 11, 2022
@ManaSugi ManaSugi mentioned this issue Apr 19, 2022
Merged
@ManaSugi
Copy link
Member Author

This issue was fixed by #141, so I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManaSugi ManaSugi

Labels
test Improvements to tests
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@ManaSugi