New API for safe(r) encoding #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all the work you've done on this. Do we know how common the deprecated functions are downstream? |
most likely used by all users of the library |
ctrlcctrlv
approved these changes
Oct 17, 2021
| @@ -649,6 +649,7 @@ load_gif( | |||
| frame->frame_no = 0; | |||
|
|
|||
| s.img_buffer = s.img_buffer_original; | |||
| // FIXME verify size is sufficient for headers | |||
There was a problem hiding this comment.
Instead of adding FIXME lines for various problems in the gif decoder, I think removing it entirely is the better move, relying on a dedicated C ABI gif decoder…
There was a problem hiding this comment.
i'm hesitant to do that without some kind of testing corpus. honestly, i'm hesitant even to merge this without such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46 shows sample code that dances fandango on core with the existing libsixel (and is an outstanding CVE). This PR deprecates the existing API, which could never be properly used (it didn't accept a length parameter for the incoming buffer against which the internally-expressed geometries could be checked). Add new forms of the deprecated functions accepting a length parameter. Exit if the length is insufficient. I doubt that this is entirely correct, or as precise as it could be, but it does seem to resolve the issue, and I've already spent more time on this busted library than I care to.
I'd love to see someone run some more tests against it before we merge.
We want an ABI bump for this, most likely (did I disable the old functions, or just deprecate them? If it's the latter, we don't technically need one).