Override the default import for supported edge runtimes #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default import had included the Node.js-specific local sqlite3 client, so all developers on platforms other than Node.js needed to use a subpackage import such as `@libsql/client/web`. This commit adds conditional imports to package.json that should allow the default import `@libsql/client` to work as `@libsql/client/web` in the edge runtimes that we support.
CodingDoug
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default import had included the Node.js-specific local sqlite3 client, so all developers on platforms other than Node.js needed to use a subpackage import such as
@libsql/client/web.This PR adds conditional imports to package.json that should allow the default import
@libsql/clientto work as@libsql/client/webin the edge runtimes that we support.Fixes #55