Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle musl on PPC32 #710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle musl on PPC32 #710

wants to merge 1 commit into from

Conversation

rossburton
Copy link
Contributor

On Linux, glibc and musl disagree over the layout of the ucontext_t structure. For more details, see the musl mailing list:

https://www.openwall.com/lists/musl/2018/02/22/1

Add conditionals to handle both the glibc and musl layout of the structures.

Closes #709.

@rossburton
Handle musl on PPC32
2e89cbc 
On Linux, glibc and musl disagree over the layout of the ucontext_t
structure.  For more details, see the musl mailing list:

https://www.openwall.com/lists/musl/2018/02/22/1

Add conditionals to handle both the glibc and musl layout of the
structures.

Closes libunwind#709.

Signed-off-by: Ross Burton <ross.burton@arm.com>
bregma
bregma approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@bregma bregma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way of verifying the changes on powerpc-linux-musl targets, but it doesn't break the powerpc-linux-gnu target so I'm OK with getting this in.

@rossburton
Copy link
Contributor Author

rossburton commented Jan 18, 2024 •
edited
Loading

Interestingly on ppc32/musl I also need to link to libatomic_ops:

../src/.libs/libunwind-ppc32.so: undefined reference to `__atomic_store_8'
../src/.libs/libunwind-ppc32.so: undefined reference to `__atomic_load_8'
../src/.libs/libunwind-ppc32.so: undefined reference to `__atomic_compare_exchange_8'

I suspected the new code is introducing a copy, but if I replace them with no-ops it still fails to link.

@bregma
Copy link
Member

bregma commented Jan 18, 2024

Sounds like a variant of #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bregma bregma bregma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to build for ppc32 on musl with mcontext_t errors
2 participants
@rossburton @bregma