1.31.0 fails to build on OpenBSD

[blueyed]

When trying to update libuv for Neovim I've noticed that it fails to build on OpenBSD (on Sourcehut):

/bin/sh ./libtool  --tag=CC   --mode=compile /usr/bin/cc -DPACKAGE_NAME=\"libuv\" -DPACKAGE_TARNAME=\"libuv\" -DPACKAGE_VERSION=\"1.31.0\" -DPACKAGE_STRING=\"libuv\ 1.31.0\" -DPACKAGE_BUGREPORT=\"https://github.com/libuv/libuv/issues\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libuv\" -DVERSION=\"1.31.0\" -DSUPPORT_FLAG_VISIBILITY=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBPTHREAD=1 -I. -I/home/build/neovim/.deps/build/src/libuv  -I/home/build/neovim/.deps/build/src/libuv/include -I/home/build/neovim/.deps/build/src/libuv/src  -I/home/build/neovim/.deps/build/src/libuv/src/unix  -g -O2 -pedantic -g -std=gnu89 -Wall -Wextra -Wno-unused-parameter -Wstrict-prototypes           -g -O2 -pedantic -g -std=gnu89 -Wall -Wextra -Wno-unused-parameter -Wstrict-prototypes -MT src/unix/libuv_la-fs.lo -MD -MP -MF src/unix/.deps/libuv_la-fs.Tpo -c -o src/unix/libuv_la-fs.lo `test -f 'src/unix/fs.c' || echo '/home/build/neovim/.deps/build/src/libuv/'`src/unix/fs.c
libtool: compile:  /usr/bin/cc -DPACKAGE_NAME=\"libuv\" -DPACKAGE_TARNAME=\"libuv\" -DPACKAGE_VERSION=\"1.31.0\" "-DPACKAGE_STRING=\"libuv 1.31.0\"" -DPACKAGE_BUGREPORT=\"https://github.com/libuv/libuv/issues\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libuv\" -DVERSION=\"1.31.0\" -DSUPPORT_FLAG_VISIBILITY=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBPTHREAD=1 -I. -I/home/build/neovim/.deps/build/src/libuv -I/home/build/neovim/.deps/build/src/libuv/include -I/home/build/neovim/.deps/build/src/libuv/src -I/home/build/neovim/.deps/build/src/libuv/src/unix -g -O2 -pedantic -g -std=gnu89 -Wall -Wextra -Wno-unused-parameter -Wstrict-prototypes -g -O2 -pedantic -g -std=gnu89 -Wall -Wextra -Wno-unused-parameter -Wstrict-prototypes -MT src/unix/libuv_la-fs.lo -MD -MP -MF src/unix/.deps/libuv_la-fs.Tpo -c /home/build/neovim/.deps/build/src/libuv/src/unix/fs.c  -fPIC -DPIC -o src/unix/libuv_la-fs.o
In file included from /home/build/neovim/.deps/build/src/libuv/src/unix/fs.c:29:
In file included from /home/build/neovim/.deps/build/src/libuv/include/uv.h:62:
/home/build/neovim/.deps/build/src/libuv/include/uv/unix.h:158:12: warning: zero size arrays are an extension [-Wzero-length-array]
  char pad[sizeof(pthread_barrier_t) - sizeof(struct _uv_barrier*)];
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/build/neovim/.deps/build/src/libuv/src/unix/fs.c:560:25: error: no member named 'f_type' in 'struct statfs'
  stat_fs->f_type = buf.f_type;
                    ~~~ ^
1 warning and 1 error generated.
gmake: *** [Makefile:2298: src/unix/libuv_la-fs.lo] Error 1

Full log: https://builds.sr.ht/~jmk/job/88268

[cjihrig]

Does #2458 fix the issue for you?

[blueyed]

Does #2458 fix the issue for you?

Yes, thanks.