Some warning from MinGW under Windows

[escherstair]

• libuv v1.35.0
• Windows 7 SP1 x64
• MinGW - GCC 7.3.0

Here is the list of some warnings I get from MinW:

libuv/src/win/fs-fd-hash-inl.h

Line 63 in 3e5d261

for (i = 0; i < ARRAY_SIZE(uv__fd_hash); ++i) {

comparison between signed and unsigned integer expressions [-Wsign-compare]

libuv/src/win/fs.c

Line 705 in 3e5d261

if (excode != EXCEPTION_IN_PAGE_ERROR) {

comparison between signed and unsigned integer expressions [-Wsign-compare]

libuv/src/win/fs.c

Line 784 in 3e5d261

int err = 0;

unused variable 'err' [-Wunused-variable]

• should be included inside #ifdef _MSC_VER / #endif

[escherstair]

Shuold I provide a PR?

[bnoordhuis]

@escherstair Yes, please!

[escherstair]

Give me some time and I'll do it.

[escherstair]

I've just added the PR #2854

[escherstair]

One thing is not clear to me:
variable zero

libuv/src/win/fs.c

Line 941 in 3654981

LARGE_INTEGER zero, pos, end_pos;

is set

libuv/src/win/fs.c

Line 966 in 3654981

zero.QuadPart = 0;

but never used.
If it's not needed I can delete it, otherwise I need to know where it should be used.

[bnoordhuis]

@escherstair zero can be removed, that was an oversight in 2c27950.

[escherstair]

I pushed a commit that removes it

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.