7.28.5 JPEG encoding problem

[jakecobb]

We've been trying to switch to the 7.28 version (for OpenSlide support), but the 7.28.5 version causes an issue with JPEG encoding in the output. Here is the error for an example image (this input is a normal LZW compressed TIFF):

$ vips im_vips2tiff 003.tif 003.tif.dzi.tif:jpeg:75,tile:256x256,pyramid,,,,8
vips warning: tiff2vips: no resolution information for TIFF image "003.tif" -- defaulting to 1 pixel per mm
vips warning: tiff2vips: no resolution information for TIFF image "003.tif" -- defaulting to 1 pixel per mm
TIFFSetField: /tmp/vips-1-XI91FW.tif: Unknown tag 317
TIFFSetField: /tmp/vips-2-7391FW.tif: Unknown tag 317
TIFFSetField: /tmp/vips-3-3491FW.tif: Unknown tag 317
TIFFSetField: /tmp/vips-4-L291FW.tif: Unknown tag 317
TIFFSetField: /tmp/vips-5-SX91FW.tif: Unknown tag 317
TIFFSetField: /tmp/vips-6-1X91FW.tif: Unknown tag 317
TIFFSetField: /tmp/vips-7-F9B2FW.tif: Unknown tag 317
TIFFSetField: /tmp/vips-8-V2B2FW.tif: Unknown tag 317
TIFFSetField: 003.tif.dzi.tif: Unknown tag 317
JPEGDecodeRaw: application buffer not large enough for all data.

This same file is processed without issue using the 7.26.7 version of libvips. It also works fine with e.g. LZW compression, only JPEG causes a problem. I built both versions of libvips against the same libtiff and other dependencies, so the issue seems to be in libvips itself.

Here is some information about the input image:

$ tiffinfo 003.tif
TIFF Directory at offset 0x3a74fb26 (980744998)
  Image Width: 28672 Image Length: 28672
  Tile Width: 512 Tile Length: 512
  Bits/Sample: 8
  Compression Scheme: LZW
  Photometric Interpretation: RGB color
  FillOrder: msb-to-lsb
  Orientation: row 0 top, col 0 lhs
  Samples/Pixel: 3
  Planar Configuration: single image plane
  Predictor: horizontal differencing 2 (0x2)

[jcupitt]

Hi Jake, this was one of the things fixed in 7.28.6. There was a problem with the gather phase of pyramid build with libtiff4 and jpeg compression. This was the commit:

jcupitt@f65f908#ChangeLog

And the current tarball should include this fix:

http://www.vips.ecs.soton.ac.uk/supported/7.28/vips-7.28.6.tar.gz

[jakecobb]

Confirming it works again in 7.28.6, thanks.