New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly back out of #125 and #115 #127
Comments
I don't think we can release a new HTTP::Message without dealing with this. |
@genio assigned ticket to you as we had discussed Windows testing on IRC. |
IIRC, we are trying to create a Windows-friendly filename right now and we're coming from a UTF-8 world -which Windows isn't when it comes to the file system. What I think we tossed around was something akin to: if ($^O eq 'MSWin32') { # possibly should do this in Cygwin as well
try {
require Win32;
my $fname = Win32::GetANSIPathName($unicode_file_path);
# do something useful with our windows-compliant filename here
}
catch {
die("We had a problem getting the appropriate Windows-compatible filename: $_");
};
} I'd need to review that area a bit further to ensure that hand-wavy bit up there is correct. |
@vanHoesel @skaji @karenetheridge Does that make sense? ^^ |
Sure, why not send that out as a -TRIAL release and see what the smokers say? |
Changes have now been reverted. |
References PRs: #115 and #125
The text was updated successfully, but these errors were encountered: