Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly back out of #125 and #115 #127

Closed
oalders opened this issue Nov 19, 2019 · 6 comments
Closed

Possibly back out of #125 and #115 #127

oalders opened this issue Nov 19, 2019 · 6 comments
Assignees
Projects

Comments

@oalders
Copy link
Member

oalders commented Nov 19, 2019

I think we need to back out of https://github.com/libwww-perl/HTTP-Message/pull/125 and https://github.com/libwww-perl/HTTP-Message/pull/115
5:01 PM 115 introduced problems which 125 tries to fix, but can't completely remedy
5:01 PM So we get more failures than in earlier releases
5:02 PM anyone opposed to reverting those PRs and *then* releasing?
5:03 PM As I recall, to debug this we'd need someone on a Windows machine and using the charset that triggers the errors

References PRs: #115 and #125

@oalders
Copy link
Member Author

oalders commented Nov 19, 2019

I don't think we can release a new HTTP::Message without dealing with this.

@oalders oalders added this to To do in ToDo Nov 19, 2019
@oalders
Copy link
Member Author

oalders commented Nov 19, 2019

@genio assigned ticket to you as we had discussed Windows testing on IRC.

@genio
Copy link
Member

genio commented Nov 25, 2019

IIRC, we are trying to create a Windows-friendly filename right now and we're coming from a UTF-8 world -which Windows isn't when it comes to the file system.

What I think we tossed around was something akin to:

if ($^O eq 'MSWin32') { # possibly should do this in Cygwin as well
    try {
        require Win32;
        my $fname = Win32::GetANSIPathName($unicode_file_path);
        # do something useful with our windows-compliant filename here
    }
    catch {
        die("We had a problem getting the appropriate Windows-compatible filename: $_");
    };
}

I'd need to review that area a bit further to ensure that hand-wavy bit up there is correct.

@genio
Copy link
Member

genio commented Nov 25, 2019

@vanHoesel @skaji @karenetheridge Does that make sense? ^^

@karenetheridge
Copy link
Member

Sure, why not send that out as a -TRIAL release and see what the smokers say?

@oalders
Copy link
Member Author

oalders commented Feb 4, 2020

Changes have now been reverted.

@oalders oalders closed this as completed Feb 4, 2020
ToDo automation moved this from To do to Done Feb 4, 2020
@haarg haarg unpinned this issue Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ToDo
  
Done
Development

No branches or pull requests

3 participants