Resubmit PR 249 #347
Merged
Resubmit PR 249 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps HTML::Form to 6.08 to fix a bug that would not allow us to set the content from a header without the file argument present. It also fixes another bug where the code blew up if a non-existent field was requested.
simbabque
force-pushed
the
simbabque/pr-249
branch
from
04a308a
to
525caf8
Compare
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 88.73% 88.83% +0.10%
==========================================
Files 3 3
Lines 852 860 +8
Branches 232 235 +3
==========================================
+ Hits 756 764 +8
Misses 36 36
Partials 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
oalders
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps HTML::Form to 6.08.
Closes #249.
Fixes #198.