Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy test on Windows #358

Merged
merged 5 commits into from
Dec 29, 2020
Merged

Fix proxy test on Windows #358

merged 5 commits into from
Dec 29, 2020

Conversation

oalders
Copy link
Member

@oalders oalders commented Dec 23, 2020

Fixes #357
Fixes #363

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #358 (fbf3cbd) into master (3be6c8e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   59.42%   59.42%           
=======================================
  Files          15       15           
  Lines        1385     1385           
  Branches      387      387           
=======================================
  Hits          823      823           
  Misses        379      379           
  Partials      183      183           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be6c8e...fbf3cbd. Read the comment docs.

@oalders oalders force-pushed the oalders/proxy-tests branch 4 times, most recently from 6b459ed to 17a35bc Compare December 23, 2020 19:20
Break up jobs by OS

Don't run author tests on Windows

Install sendmail on Linux

Install develop prereqs on Linux and macOS
On CI Perl 5.12 is failing with 0.94
@oalders oalders marked this pull request as ready for review December 23, 2020 20:28
Copy link
Contributor

@simbabque simbabque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oalders oalders merged commit e258abe into master Dec 29, 2020
@oalders oalders deleted the oalders/proxy-tests branch December 29, 2020 22:02
@oalders
Copy link
Member Author

oalders commented Dec 29, 2020

Thanks @simbabque!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing of LWP 6.50 on Windows [rt.cpan.org #133936] Windows-only failure with base/ua.t
2 participants