Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_mixer_bidi_sync part 2 #689

Open
neumatho opened this issue Oct 19, 2023 · 6 comments
Open

test_mixer_bidi_sync part 2 #689

neumatho opened this issue Oct 19, 2023 · 6 comments
Labels
Milestone

Comments

@neumatho
Copy link
Contributor

Hi again,

Created a new issue. This is a reference to issue #681.

I just saw now, that you have replaced the wrong argument in xmp_set_player for interp. It is the last argument in the method call that should be replaced. I tried to make a new PR with this change, but when running the test it begin to fail on the first mixer test. Probably because it now uses the nearest instead of spline, which was hardcoded before.

So I don't know what is needed to fix it or if you still want the test.

@sezero
Copy link
Collaborator

sezero commented Oct 19, 2023

Send a patch please?

@neumatho
Copy link
Contributor Author

diff --git a/test-dev/test_mixer_bidi_sync.c b/test-dev/test_mixer_bidi_sync.c
index 2a68b7d8..620a1c92 100644
--- a/test-dev/test_mixer_bidi_sync.c
+++ b/test-dev/test_mixer_bidi_sync.c
@@ -24,7 +24,7 @@ static void bidi_sync_test_mode(xmp_context opaque, int rate, int interp, const
        int i, j;

        xmp_start_player(opaque, rate, XMP_FORMAT_MONO);
-       xmp_set_player(opaque, interp, XMP_INTERP_SPLINE);
+       xmp_set_player(opaque, XMP_PLAYER_INTERP, interp);

        for (i = 0; i < RENDER_FRAMES; i++) {
                xmp_play_frame(opaque);

@sezero
Copy link
Collaborator

sezero commented Oct 19, 2023

@AliceLR: This is good yes?

@AliceLR
Copy link
Contributor

AliceLR commented Oct 19, 2023

Yes, sorry I missed that before.

@sezero
Copy link
Collaborator

sezero commented Oct 20, 2023

Unfortunately this results in a failure with make devcheck :

test 563: test_mixer_bidi_sync: at test_mixer_bidi_sync.c:34: xm:nearest:8k: **fail**

@neumatho
Copy link
Contributor Author

Yeah, that was the same result I got.

@AliceLR AliceLR added the bug label Feb 11, 2024
@AliceLR AliceLR added this to the 4.6.1 milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants