Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItChat's MIT license is not recognised #462

Closed
danielcompton opened this issue Sep 16, 2020 · 2 comments
Closed

ItChat's MIT license is not recognised #462

danielcompton opened this issue Sep 16, 2020 · 2 comments

Comments

@danielcompton
Copy link

Describe the bug

https://github.com/littlecodersh/ItChat uses the MIT license, but licensee doesn't detect their license correctly.

Steps to reproduce the behavior

$ licensee detect littlecodersh/ItChat --remote
License:        NOASSERTION
Matched files:  LICENSE
LICENSE:
  Content hash:  fe946012c87c55c00c38b4f060dffa862111f467
  License:       NOASSERTION
  Closest non-matching licenses:
    MIT similarity:      92.93%
    NCSA similarity:     71.60%
    BSL-1.0 similarity:  63.16%

Expected behavior

ItChat's license is detected as MIT.

Additional context

Diffing this seems pretty similar, the main differences are line breaks and the header

-MIT License
-
-Copyright (c) [year] [fullname]
+**The MIT License (MIT)**
+
+Copyright (c) 2017 LittleCoder ([littlecodersh@Github](https://github.com/littlecodersh))
@mlinksva
Copy link
Contributor

mlinksva commented Sep 16, 2020

Same problem as #435 (markdown normalization regression), fixed by #459.

FWIW licensee can tell you what it thinks the diff is (after normalization). Licensee 9.14.0:

$ bundle exec licensee diff https://github.com/littlecodersh/ItChat --license=mit
Comparing to MIT License:
Input Length:      1096
License length:    1020
Similarity:      92.93%
diff --git a/LICENSE b/LICENSE
index 0ce42af..31e4ce0 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,3 +1,4 @@
{+the mit license (mit) copyright (c) 2017 littlecoder (littlecodersh@github)+}
permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "software"), to deal in
the software without restriction, including without limitation the rights to

HEAD:

$ bundle exec licensee diff https://github.com/littlecodersh/ItChat --license=mit
Comparing to MIT License:
Input Length:       1020
License length:     1020
Similarity:      100.00%
Exact match!

@danielcompton
Copy link
Author

Thanks for the quick response. Sorry about the duplicate, I should have checked this running from source, not the latest released version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants