Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional text after 100% match results in NOASSERTION #498

Closed
SamuraiAku opened this issue Jun 9, 2021 · 1 comment
Closed

Additional text after 100% match results in NOASSERTION #498

SamuraiAku opened this issue Jun 9, 2021 · 1 comment

Comments

@SamuraiAku
Copy link

I have an MIT license file that returns a 100% match. Then I want to add one line of text after the license saying something like
Please see THIRDPARTY.md for license information for other software used in this project

That reduces the match to 86.92% and the license detected to NOASSERTION.

It looks like anything more than 3-4 random characters after the license text is enough to bring the match below 99% and get NOASSERTION.

Is there some sort of comment character I could add that would prevent licensee from processing that line and get me back up to 100%?

@mlinksva
Copy link
Contributor

mlinksva commented Jun 9, 2021

Is there some sort of comment character I could add that would prevent licensee from processing that line and get me back up to 100%?

There is, but absolutely no promises it'll continue to work, e.g., if we eventually swapped the default matcher for one entirely driven by SPDX matching rules.

With that caveat, anything after a line consisting of end of terms and conditions is discarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants