Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Disable cloud analysis when using external-engine #11526

Open
SnowballSH opened this issue Sep 11, 2022 · 3 comments
Open

Enhancement: Disable cloud analysis when using external-engine #11526

SnowballSH opened this issue Sep 11, 2022 · 3 comments

Comments

@SnowballSH
Copy link
Contributor

Problem

When external-engine is enabled, say on a tournament broadcast page where games are analyzed by hundreds of users, lichess displays the result of cloud analysis instead of our local external-engine when cloud analysis depth is higher.

The user is using external-engine usually because they want to see the analysis using their own engine instead of the wasm stockfish lichess gives. Even if someone ran stockfish at a higher depth than user's external-engine, it is not what exactly the user want (plus, user's local engine may give a more accurate analysis even at a lower depth than the wasm stockfish).

Current Behaviour

Cloud analysis result is shown even when external-engine is enabled and running.

Expected Behaviour

(Default?) option to disable cloud analysis when external-engine is enabled.

@SnowballSH
Copy link
Contributor Author

I can try to implement it, but I might need some help understanding the option tabs and external-engine detection.
Or someone else can do it if they feel it's an easy work for them.

@benediktwerner
Copy link
Member

benediktwerner commented Sep 11, 2022

Duplicate of #11237

As mentioned there, hiding cloud eval when an external engine is in use is probably the preferred solution. cloud eval is handled in evalCache.ts, it should be relatively simple to make it not request an eval when an external engine is registered if you want to give it a shot. Feel free to ask on Discord if you need some more directions.

@benediktwerner benediktwerner marked this as a duplicate of #11237 Sep 11, 2022
@SnowballSH
Copy link
Contributor Author

I am unable to fix this issue because I am facing too many problems with setting up fishnet, cloud analysis, external engine sockets, etc.
I think it is best for someone who have a complete setup to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Nice to have
Development

No branches or pull requests

2 participants