Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding completed game from analysis board to study results in game result comment twice #13206

Open
jxu opened this issue Jul 12, 2023 · 6 comments
Labels

Comments

@jxu
Copy link

jxu commented Jul 12, 2023

Exact URL of where the bug happened

https://lichess.org/study/as

Steps to reproduce the bug

  1. Open completed game in Analysis Board such as https://lichess.org/Fbyt4JCs/black#31
  2. Hamburger menu > Study Button > Add to some study
  3. Look at move list

What did you expect to happen?

Lichess adds a comment to the last move once

What happened instead?

Lichess leaves a comment like "0-1 Black wins by checkmate." twice

Operating system

Ubuntu 20.04

Browser and version (or alternate access method)

Firefox 108

Additional information

Seems to happen regardless if computer analysis was conducted or not.

@jxu jxu added the bug label Jul 12, 2023
@jxu jxu changed the title Computer analysis adds game result comment twice Adding completed game from analysis board to study results in game result comment twice Jul 12, 2023
@lenguyenthanh
Copy link
Member

Just look at it again, I don't think this is a bug, one is from the pgn, and another one is from UI (I guess). If you don't like the duplicated you can delete the comment at the end of the game.

@jxu
Copy link
Author

jxu commented Jul 18, 2023

I think it is a bug in the process of adding a game to the study. It shows up in the PGN twice.

lichess_study_game-study_mykolamykolai-1375-jaxu-1483_by_jaxu_2023.07.18.txt

image

It seems to behave differently on mobile firefox than desktop firefox. Example study output https://lichess.org/study/xzvOGYmS/YmWPxotb chapter 1 is from mobile site, chapters 2 and 3 from desktop site

@lenguyenthanh
Copy link
Member

ah, there are two comments, I only saw one when I tried to reproduce. I also use firefox desktop.

Is this still happen today (or yesterday for that matter?)

@jxu
Copy link
Author

jxu commented Jul 20, 2023

Yes it's still happening on my desktop.

@lenguyenthanh
Copy link
Member

Hey, I tried again, but couldn't reproduce, ex: https://lichess.org/study/4NTZYu1c.

@jxu
Copy link
Author

jxu commented Jul 25, 2023

I tried it again and it is still happening when adding it to my study linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants