Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application for the tournament in advance: The rating remains unchanged in the table with rating changes. #13316

Open
Tevajs opened this issue Jul 28, 2023 · 4 comments
Labels
improvement Small incremental improvement to an existing feature prospect For long-term consideration

Comments

@Tevajs
Copy link

Tevajs commented Jul 28, 2023

Exact URL of where the bug happened

lichess.org

Steps to reproduce the bug

Sign up early for the tournament. Play games for rating. In the tournament, your rating will not change.

What did you expect to happen?

Rating must change

What happened instead?

Rating remains the same as at the time of application

Operating system

Windows 11

Browser and version (or alternate access method)

Google Chrome 112.0.5615.138

Additional information

https://lichess.org/forum/lichess-feedback/lichess-bug-3-wins-in-profile-minus-in-rating
My forum bug report.
Side effects from this are also attached

@Tevajs Tevajs added the bug label Jul 28, 2023
@Diordany
Copy link

Diordany commented Jul 28, 2023

I reproduced the bug on my local Lichess build:

results

The first match was played outside of the tournament, after both user1 and user2 applied for the tournament. The rating of user1 would go from 1638 to 1729, but the rating is still 1638 at the beginning of the first match of the tournament (as @Tevajs points out). However, at the start of the second match of the tournament, the rating is correct again as it would've gone from 1729 to 1772 in the match before.

To summarize: the rating only appears to be incorrect for the first match of the tournament (second match in the picture).

@kraktus
Copy link
Member

kraktus commented Jul 29, 2023

Hello,

For more context, it's been like that for years to avoid stressing the db when starting a big tournament (imagine a marathon with 20k users to update their rating just before the start). However with the recent change in user_perf it's possibly less expensive.

The issue would be to do it efficiently and also stress test the change before going live, so not easy.

@kraktus kraktus added prospect For long-term consideration improvement Small incremental improvement to an existing feature and removed bug labels Jul 29, 2023
@Tevajs
Copy link
Author

Tevajs commented Jul 29, 2023

Well, about the decision: you can't play any games after you signed up for a tournament on chesscom.

@DrSteinbot
Copy link

Just from a performance standpoint wouldn't it more efficient to update the players rating in the listing after he played a game, so that the players who aren't playing won't be the server and the ratings wouldn't be pulled all at the same time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Small incremental improvement to an existing feature prospect For long-term consideration
Projects
None yet
Development

No branches or pull requests

4 participants