flagged accounts should not appear on TV

[danispringer]

Are we sure we want flagged accounts featured on TV?

[SergioGlorias]

ok, maybe it's difficult to disclose
but in any case it is against the computer and not against a person

[randompearl-stack]

ok, maybe it's difficult to disclose but in any case it is against the computer and not against a person

Even if it is against the computer, isn't featuring flagged accounts on TV condoning their behavior to some extent? Also, the example shown is a computer match, but the issue concerns all the TV sections. It is highly unlikely, but the TV could feature a top player who was just found to violate ToS.

[tors42]

Jotting down a "simple" solution which works on my empty test system (tested with bots),
but maybe the penalty of performing the engine count on each notification of a started game isn't a feasable approach on non-test system... 😅

tv/src/main/Env.scala

...
     lightUserSync: lila.core.LightUser.GetterSync,
+    userApi: lila.core.user.UserApi,
...

tv/src/main/TvSyncActor.scala

...
     lightUserApi: lila.core.user.LightUserApi,
+    userApi: lila.core.user.UserApi,
...

     case lila.core.game.StartGame(g) =>
       if g.hasClock then
+        userApi
+          .countEngines(g.userIds)
+          .map(nb =>
+            if nb == 0 then
               val candidate = Tv.Candidate(g, g.userIds.exists(lightUserApi.isBotSync))
               channelActors
                 .collect {
                   case (chan, actor) if chan.filter(candidate) => actor
                 }
                 .foreach(_.addCandidate(g))
+          )
...