Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study sharing URL: wrongly redirects to newly created chapter #14959

Open
paul2t opened this issue Mar 24, 2024 · 3 comments
Open

Study sharing URL: wrongly redirects to newly created chapter #14959

paul2t opened this issue Mar 24, 2024 · 3 comments

Comments

@paul2t
Copy link

paul2t commented Mar 24, 2024

Exact URL of where the bug happened

https://lichess.org/study

Steps to reproduce the bug

  1. Go to https://lichess.org/study
  2. Create a new study
  3. Click "START"
  4. Click "CREATE CHAPTER"
  5. Click "Add a new chapter"
  6. Click "CREATE CHAPTER"
  7. Go to "Share & Export"
  8. Copy "Study URL"
  9. Open the study URL

What did you expect to happen?

I expected the study to open chapter 1.

What happened instead?

It opened chapter 2. If we make more chapters, it will land on the last one when opening the study URL.

Operating system

Windows 11

Browser and version (or alternate access method)

Chrome 122

Additional information

No response

@paul2t paul2t added the bug label Mar 24, 2024
@kraktus kraktus added the good first issue Narrow in scope (but not necessarily easy) label Mar 25, 2024
@kraktus kraktus changed the title New study default chapter Of by one chapter, when sharing as url Mar 25, 2024
@kraktus kraktus changed the title Of by one chapter, when sharing as url Study: off by one chapter, when sharing as url Mar 25, 2024
@paul2t
Copy link
Author

paul2t commented Mar 26, 2024

@kraktus I'm not sure it's an off by one issue. If you create a third chapter, it will land on the third one. If you create 60 chapters, it will land on the 60th chapter. I think it is the last created chapter. I need to check what happens when the last chapter is reordered to the first position in the study.

Also, I noticed that after some time without modifying the study, the issue corrects itself and the study url lands on the first chapter.
But as soon as we create a new chapter, the issue is back and this new chapter becomes the default one for the study URL.

@kraktus kraktus removed bug good first issue Narrow in scope (but not necessarily easy) labels Mar 26, 2024
@kraktus kraktus changed the title Study: off by one chapter, when sharing as url Study sharing URL: redirects to newly created chapter Mar 26, 2024
@brollin
Copy link
Collaborator

brollin commented Mar 27, 2024

If you would like to link to a specific chapter in is study, you should use the "Current chapter URL". Seems like that should solve this issue?

Also just noting that there is a setting to keep everyone synced to the same position in a study, which is on by default. Just something to be aware of, guessing you want that off.

@paul2t
Copy link
Author

paul2t commented Mar 27, 2024

@brollin yes, having the link to the first chapter does "fix" this issue. Although removing or reordering the first chapter would bring it back, it's a minor issue as we don't do that often. The current behavior with the chapter in the url is appreciated.

I also tried with sync disabled and I still have the bug when sharing the url of the study.

@kraktus kraktus changed the title Study sharing URL: redirects to newly created chapter Study sharing URL: wrongly redirects to newly created chapter Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants