Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a nice 404 page for /fide not found #15457

Closed
TBestLittleHelper opened this issue Jun 7, 2024 · 3 comments
Closed

Make a nice 404 page for /fide not found #15457

TBestLittleHelper opened this issue Jun 7, 2024 · 3 comments
Assignees
Labels
good first issue Narrow in scope (but not necessarily easy)

Comments

@TBestLittleHelper
Copy link
Contributor

TBestLittleHelper commented Jun 7, 2024

Sometimes a player in broadcast will have a Fide ID, on the FIDE website. But the Fide ID is not yet part of Lichess' /fide page. When you click on the clickable player name in the broadcast you get the generic 404 page.

A fide 404 page, with some text should work. A quick draft :

We could not find anyone with this FIDE ID, make sure the ID number is correct. If the player appear on the official FIDE website, then the player was not included in the latest rating export from FIDE. Official exports are provided once a month and includes players who have at least one official rating.

Note : Not sure if we are using legacy format or not. Seems like players without any rating might be excluded from the modern export.
https://ratings.fide.com/download_lists.phtml

EDIT: To be clear : The 404 link from broadcast is https://lichess.org/fide/1/redirect where the 1 is the fideID
Searching for an ID does look ok : https://lichess.org/fide?q=99999999999 even if the ID can't be found

@kraktus kraktus added the good first issue Narrow in scope (but not necessarily easy) label Jun 9, 2024
@Jaishree2310
Copy link

@kraktus @TBestLittleHelper Can you please assign this to me?
Thanks!

@ornicar
Copy link
Collaborator

ornicar commented Jun 14, 2024

It's been 3 days. My turn.

@ornicar
Copy link
Collaborator

ornicar commented Jun 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Narrow in scope (but not necessarily easy)
Projects
Archived in project
Development

No branches or pull requests

4 participants