Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslatable strings in Round.scala #3233

Open
thomas-daniels opened this issue Jul 6, 2017 · 4 comments
Open

Untranslatable strings in Round.scala #3233

thomas-daniels opened this issue Jul 6, 2017 · 4 comments
Labels
Projects

Comments

@thomas-daniels
Copy link
Member

https://github.com/ornicar/lila/blob/cc53a33d24dc24d0f439e711da8092859ac07f4d/modules/round/src/main/Round.scala has several untranslatable strings (search for untranslated to find them) that get fed into https://github.com/ornicar/lila/blob/cc53a33d24dc24d0f439e711da8092859ac07f4d/modules/round/src/main/Messenger.scala#L13

@thomas-daniels
Copy link
Member Author

I was going to attempt this, but I have no clue how I can pass a UserContext to the Messenger.

@ornicar
Copy link
Collaborator

ornicar commented Jul 6, 2017

You can't. At the time messages are posted in the chat, there is no way of knowing the language of the user who will read them.

@niklasf niklasf added the i18n label Jul 6, 2017
@niklasf niklasf added this to Translation system in I18N Jul 6, 2017
@stale
Copy link

stale bot commented Dec 14, 2019

There has been no activity on this issue for 2 years. It will be automatically closed in 2 weeks.
If the issue is still relevant, please briefly explain (or remove the label). Feel free to reopen at any time.

@stale stale bot added the stale label Dec 14, 2019
@niklasf niklasf removed the stale label Dec 14, 2019
@stale
Copy link

stale bot commented Jan 3, 2022

There has been no activity on this issue for 2 years. It will be automatically closed in 2 weeks.
If the issue is still relevant, please briefly explain (or remove the label). Feel free to reopen at any time.

@stale stale bot added the stale label Jan 3, 2022
@niklasf niklasf removed the stale label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
I18N
Translation system
Development

No branches or pull requests

3 participants