Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

race condition in challenge acceptance #5566

Open
bruce-ricard opened this issue Oct 5, 2019 · 0 comments
Open

race condition in challenge acceptance #5566

bruce-ricard opened this issue Oct 5, 2019 · 0 comments
Labels
bug can't reproduce Needs steps to reproduce

Comments

@bruce-ricard
Copy link

I clicked on a first challenge in the lobby. I saw the loading spinning animation like usual, which lasted a bit longer than usual (about 2-3 seconds), and then I got back to the lobby. I tried clicking a second game, same result. A third game, same result.
Then after a couple of seconds, out of nowhere, the game page shows up and I'm asked to play. I play my first move and a new game starts on top of it. I try to fix everything but I guess I was too slow, because before I know it my profile contains 2 aborted games and a lost one after 1 move.

My internet connection was quite bad at that moment, which is what might have triggered the race condition.

It feels like you should have some sort of mutex per user to prevent them from successfully accepting multiple challenges at the same time. When you go to the lobby while a game is in progress, you usually see a message saying that you already have a game in progress. Maybe this message needs to be triggered as soon as a challenge is accepted, not only when the game "starts", whatever that means.

@niklasf niklasf added bug can't reproduce Needs steps to reproduce labels Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug can't reproduce Needs steps to reproduce
Projects
None yet
Development

No branches or pull requests

2 participants