Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractional rating part not used correctly in determining ranking #6122

Open
thomas-daniels opened this issue Mar 5, 2020 · 1 comment
Open

Comments

@thomas-daniels
Copy link
Member

https://lichess.org/@/ODMWND has 2328.21 rating points in Antichess and is ranked 2nd.
https://lichess.org/@/AlekseyGuru has 2328.89 rating points and is ranked 3rd.

It doesn't look like a caching issue because Aleksey was ahead of ODMWND for hours, then ODMWND gained some points (didn't lose any) and got ahead of him.

@greg-finley
Copy link
Contributor

Weird. I thought it would be sorted from the db here: https://github.com/ornicar/lila/blob/master/modules/user/src/main/RankingApi.scala#L66

I think maybe rating: Double here? https://github.com/ornicar/lila/blob/de6ba687cdd25ceb4e7a59274af5afc5e1702e30/modules/user/src/main/User.scala#L159

I think I'm too lazy to exhaustively test this though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants