-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab Session Manager baloons Firefox WebExtensions process to >20GB in game replay with Stockfish in Browser on #6481
Comments
Need more to data have a chance at figuring this out.
|
The WebExtensions process is where your add-ons are. Chances are much more likely you have an add-on that is leaking memory, than that there's a problem in lichess or Firefox. The lichess.org engine runs in the Content Processes. |
Can you take a look at about:memory, click "measure", and see if there's anything that stands out in the WebExtensions process? |
I see, this might be a bad interaction with one of my add-ons. I will make a measurement next time I observe the said behavior. |
macOS Mojave 10.14.6
75.0 (64-bit)
WASM
How can I modify these settings?
Machine has 2 cores and 16 GB RAM)
Unfortunately, in the measurements it says:
In the other sections, there are a few mentions of
However, there is one large allocation under
For that measurement, the "Main Process" had allocated 16GB:
|
(WASM) guard pages don't actually use any real memory: https://bugzilla.mozilla.org/show_bug.cgi?id=1469278#c10 It may be allocated but it's not in use so it is available for other applications. I would expect those to have been under Content Process, not WebExtensions process. I'll check on macOS whether the details of the WebExtensions process report would help to identify what's going on there despite that warning (and if so I may ask for an additional log). |
Going to close, because it appear to be a general browser issue that will not require a Lichess specific solution or workaround. Please reopen if that's a wrong assessment. |
I do not have the privileges to reopen. I can only stress that this only ever and reproducibly happens with lichess.org on Firefox. Basically, I need to restart Firefox whenever I did a game replay with local Stockfish on. |
Can you describe why you "Need to restart Firefox"? Does it hang/freeze? |
It is still the OP, quoting:
I have to restart Firefox since it has gobbled up Gigs of memory and my system responds badly because of Swap usage. |
Ok, so if swap is used it's not just a number, but really physical memory. |
First thing to do would be to test with a Firefox running in safe mode, i.e. all extensions disabled. As already mentioned, if the leaking process is the WebExtensions process, that means you have an add-on that is not freeing the memory. |
Thanks @gcp. Safe mode looks good so far, I'll observe it for a bit longer.
Nothing too exotic, I'd say, but I'll have to try out disabling them one-by-one to be able to tell you more. |
And the winner is.... --- TAB SESSION MANAGER Seems like TSM has shown problematic memory behavior in other situations as well: sienori/Tab-Session-Manager#337 Still puzzling why this ballooning of TSM only occurs when I do a game replay with local Stockfish on... Maybe it tries to save too much of the state of the lichess window (shooting in the dark). |
Indeed. Thank you, and thanks gcp. For now let's assume that this must be fixed in the extension, but of course I am not opposed to adding a workaround to lila, if the possibility arises. |
I had to shutdown Firefox twice today since it had allocated >20GB in the WebExtensions process. I observed this behavior in game analysis mode with Stockfish in Browser on. If I do moves in game analysis mode with the client-side Stockfish for a longer time, memory consumption goes through the roof. Is the engine leaking memory?
The text was updated successfully, but these errors were encountered: