Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

King in check board highlight #86

Closed
ghost opened this issue Mar 21, 2023 · 6 comments
Closed

King in check board highlight #86

ghost opened this issue Mar 21, 2023 · 6 comments
Labels
feature New feature
Milestone
Alpha

Comments

@ghost
Copy link

ghost commented Mar 21, 2023 •
edited by ghost

Screenshot_20230321_161827

Black is in check but the red mark on the king does not show.

This issue also applies for white.

Steps to reproduce:
Go to puzzles.
Get in check as black.
@ghost ghost changed the title Check mark does now show in puzzles Check mark does not show in puzzles Mar 21, 2023
@veloce
Copy link
Contributor

veloce commented Mar 24, 2023

This is not a bug, more a feature request. I won't necessarily implement it.

@veloce veloce added the enhancement Improve existing feature label Mar 24, 2023
@veloce veloce changed the title Check mark does not show in puzzles King in check board highlight Mar 24, 2023
@veloce veloce added feature New feature and removed enhancement Improve existing feature labels Mar 24, 2023
@ghost
Copy link
Author

ghost commented Mar 27, 2023

I dont know if its a bug or not but as lichess player i expect a red mark to appear on the king that is checked like the website and the capacitor app.

@veloce
Copy link
Contributor

veloce commented Mar 27, 2023

Make a pull request if you like.

@Mansour-J
Copy link

I dont know if its a bug or not but as lichess player i expect a red mark to appear on the king that is checked like the website and the capacitor app.

+1 I believe it's important to have consistent behavior.

@NewSupKaizo55
Copy link

Same here. Most chess websites/software, just like main Lichess indicates check somehow, usually with the red highlight. I think it's safe to say most people would prefer to have this as a feature.

@veloce
Copy link
Contributor

veloce commented Apr 30, 2023

Done in 84a0ccc

@veloce veloce closed this as completed Apr 30, 2023
@veloce veloce added this to the Beta 1 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
Alpha
Development

No branches or pull requests
3 participants
@veloce @Mansour-J @NewSupKaizo55