Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are tests working? #100

Closed
Einenlum opened this issue Aug 1, 2019 · 2 comments
Closed

Are tests working? #100

Einenlum opened this issue Aug 1, 2019 · 2 comments

Comments

@Einenlum
Copy link

Einenlum commented Aug 1, 2019

Hi liebig,

Thank you for your work. I'm surprised by the tests. Where is the TestCase class coming from? Considering that:
1/ There is no use statement
2/ There is no phpunit dependency declared as dev dependency in composer

Are the tests supposed to work? Are there obsolete?

Thanks!

@liebig
Copy link
Owner

liebig commented Aug 1, 2019

I'm not sure if the tests are still running. A long time ago they were working. But they may not work anymore. But in the meantime I have learned a lot and would build and write the tests differently. Therefore I would call them obsolete in ther current form.

@liebig
Copy link
Owner

liebig commented Aug 15, 2019

Closed due to inactivity

@liebig liebig closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants