Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambigious API #27

Closed
romainthomas opened this issue Apr 27, 2017 · 0 comments
Closed

Ambigious API #27

romainthomas opened this issue Apr 27, 2017 · 0 comments
Assignees
@romainthomas
Labels
API PE
Milestone
0.7.0

Comments

@romainthomas
Copy link
Member

In the PE API, get_content_from_virtual_address takes a relative virtual address.
@romainthomas romainthomas added this to the 0.7.0 milestone Apr 27, 2017
@romainthomas romainthomas self-assigned this Apr 27, 2017
romainthomas added a commit that referenced this issue Jul 18, 2017
@romainthomas
Fix some ambiguous API (fix #27)
907e853 
PE::Binary::get_content_from_virtual_address can now take either:
  Absolute Virtual Address / Relative Virtual Address

In the PE Python API:
  * Merge 'PE.parse_from_raw' and 'PE.parse'
  * Change 'PE.Binary.section_from_virtual_address' to 'PE.Binary.section_from_rva'

In the PE C++ API:
  * Change 'Binary::section_from_virtual_address' to 'Binary::section_from_rva'
romainthomas added a commit that referenced this issue Jan 17, 2022
@romainthomas
Fix some ambiguous API (fix #27)
f4372d0 
PE::Binary::get_content_from_virtual_address can now take either:
  Absolute Virtual Address / Relative Virtual Address

In the PE Python API:
  * Merge 'PE.parse_from_raw' and 'PE.parse'
  * Change 'PE.Binary.section_from_virtual_address' to 'PE.Binary.section_from_rva'

In the PE C++ API:
  * Change 'Binary::section_from_virtual_address' to 'Binary::section_from_rva'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romainthomas romainthomas

Labels
API PE
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@romainthomas