Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: command proxy for addons api #143

Open
lifeart opened this issue Jul 6, 2020 · 0 comments
Open

Feat: command proxy for addons api #143

lifeart opened this issue Jul 6, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@lifeart
Copy link
Owner

lifeart commented Jul 6, 2020

usecase:

currently we have proxy command, in extension itself, it allow execute any VSCode command, and return execution results into any command

https://github.com/lifeart/vscode-ember/blob/master/src/extension.ts#L98

we need to create api to return result back to extension server and pass it down to addon

for example:

1.) addon: execute command ["create-file", "els:after-create-file"]
2.) server: execute command ["proxy-command", "create-file", "els:after-create-file" ]
3.) vscode: execute command "create-file"
4.) passing result back to extension
5.) extension passing result back to server
6.) server passing result back to "els:after-create-file", registered in addon

addon_command -> api_command -> extension_proxy -> (vscode command evaluation) -> extension_proxy -> api_command -> other_addon_command

@lifeart lifeart added the enhancement New feature or request label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant