Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support jump to definition from parent to child app and tests #234

Conversation

suchitadoshi1987
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #234 (d92f452) into component-context-info-origin (8082482) will decrease coverage by 2.19%.
The diff coverage is 66.63%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           component-context-info-origin     #234      +/-   ##
=================================================================
- Coverage                          71.63%   69.43%   -2.20%     
=================================================================
  Files                                 17       39      +22     
  Lines                                913     3288    +2375     
  Branches                             180      689     +509     
=================================================================
+ Hits                                 654     2283    +1629     
- Misses                               259     1001     +742     
- Partials                               0        4       +4     
Impacted Files Coverage Δ
src/reference-provider/entry.ts 90.00% <ø> (ø)
...addons/core/code-actions/template-lint-comments.ts 10.76% <10.76%> (ø)
src/utils/usages-api.ts 29.26% <13.04%> (-70.74%) ⬇️
.../builtin-addons/core/script-completion-provider.ts 40.27% <14.28%> (ø)
...in-addons/core/code-actions/template-lint-fixes.ts 15.00% <15.00%> (ø)
...ddons/core/code-actions/typed-template-comments.ts 15.15% <15.15%> (ø)
src/builtin-addons/core/code-actions/base.ts 20.93% <20.93%> (ø)
src/code-action-provider/entry.ts 33.33% <33.33%> (ø)
src/estree-utils.ts 76.19% <33.33%> (-23.81%) ⬇️
src/symbols/hbs-document-symbol-provider.ts 54.54% <42.85%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29b112...d92f452. Read the comment docs.

@suchitadoshi1987 suchitadoshi1987 changed the title failing parent defintion case feat: Support jump to definition from parent to child app and tests Apr 12, 2021
test/integration-test.ts Outdated Show resolved Hide resolved
@lifeart lifeart merged commit 24f33e5 into lifeart:component-context-info-origin Apr 12, 2021
lifeart pushed a commit that referenced this pull request Apr 12, 2021
# [1.6.0](v1.5.0...v1.6.0) (2021-04-12)

### Features

* Support jump to definition from parent to child app and tests ([#234](#234)) ([24f33e5](24f33e5))
suchitadoshi1987 pushed a commit to suchitadoshi1987/ember-language-server that referenced this pull request Feb 9, 2022
# [1.2.0](v1.1.0...v1.2.0) (2022-02-09)

### Bug Fixes

* update debounce implementation ([lifeart#250](https://github.com/suchitadoshi1987/ember-language-server/issues/250)) ([4675e19](4675e19))

### Features

* ability to ignore LS initialization on unneeded projects ([lifeart#242](https://github.com/suchitadoshi1987/ember-language-server/issues/242)) ([fc5acf4](fc5acf4))
* add has block params into builtin helper, extended in-repo-addons support ([lifeart#224](https://github.com/suchitadoshi1987/ember-language-server/issues/224)) ([acd71a0](acd71a0))
* add support for multinamespaced components ([lifeart#212](https://github.com/suchitadoshi1987/ember-language-server/issues/212)) ([6b03c83](6b03c83))
* ember-template-lint severity converter (support different severity kinds) ([be3e923](be3e923))
* Improve linting speed & ability to disable default linting ([lifeart#244](https://github.com/suchitadoshi1987/ember-language-server/issues/244)) ([472c0fe](472c0fe))
* improve template-completion caching ([lifeart#248](https://github.com/suchitadoshi1987/ember-language-server/issues/248)) ([afb2d8d](afb2d8d))
* Namespace components (batman syntax) ([2ea63d9](2ea63d9))
* Support `workspace/didChangeConfiguration` event ([lifeart#254](https://github.com/suchitadoshi1987/ember-language-server/issues/254)) ([05d97cb](05d97cb))
* Support jump to definition from parent to child app and tests ([lifeart#234](https://github.com/suchitadoshi1987/ember-language-server/issues/234)) ([24f33e5](24f33e5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants