Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: yield arguments hash autocomplete and resolve #373

Merged
merged 1 commit into from
Apr 21, 2022
Merged

feat: yield arguments hash autocomplete and resolve #373

merged 1 commit into from
Apr 21, 2022

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Mar 30, 2022 •
edited

resolves: #372

@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited

Codecov Report

Merging #373 (fe80aa5) into component-context-info-origin (24536ff) will increase coverage by 0.34%.
The diff coverage is 71.28%.

❗ Current head fe80aa5 differs from pull request most recent head 4fbb9f9. Consider uploading reports for the commit 4fbb9f9 to get more accurate results

@@                        Coverage Diff                        @@
##           component-context-info-origin     #373      +/-   ##
=================================================================
+ Coverage                          71.94%   72.29%   +0.34%     
=================================================================
  Files                                 56       57       +1     
  Lines                               4663     4844     +181     
  Branches                             899      938      +39     
=================================================================
+ Hits                                3355     3502     +147     
- Misses                              1308     1342      +34
Impacted Files Coverage Δ
src/utils/yield-context-extractor.ts 59.20% <59.20%> (ø)
src/utils/ast-helpers.ts 83.52% <78.57%> (+0.74%) ⬆️
src/utils/usages-api.ts 56.57% <84.61%> (+4.27%) ⬆️
...uiltin-addons/core/template-completion-provider.ts 92.76% <95.23%> (+0.40%) ⬆️
src/glimmer-utils.ts 50.00% <100.00%> (+5.43%) ⬆️
src/server.ts 64.15% <100.00%> (ø)
src/utils/template-tokens-collector.ts 87.91% <100.00%> (+12.38%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24536ff...4fbb9f9. Read the comment docs.

@lifeart lifeart force-pushed the yield-scope-collector branch 2 times, most recently from d7a6899 to 64fd7e6 Compare April 20, 2022 10:38
@lifeart
feat: yield context autocomplete
4fbb9f9 
update list of html tags

feat: yield context autocomplete

yield context extractor

more tests

store data in scope

fix few tests

few tests

fix meta

add meta to project

support only one kind

do not expose scopes

improve complete naming

fix failing tests

add failing test

fix few logical issues

fix more test cases

improve tests
@lifeart lifeart merged commit e157566 into component-context-info-origin Apr 21, 2022
@lifeart lifeart deleted the yield-scope-collector branch April 21, 2022 07:05
lifeart pushed a commit that referenced this pull request Apr 21, 2022
@semantic-release-bot
chore(release): 2.21.0 [skip ci]
0c51440 
# [2.21.0](v2.20.1...v2.21.0) (2022-04-21)

### Features

* yield context autocomplete ([#373](#373)) ([e157566](e157566))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yield arguments hash autocomplete
1 participant
@lifeart