Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go to definition for yield context #385

Merged

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Apr 27, 2022

go to definition support for yielded component hash from component angle path.

<MyComponent as |foo|>
  <foo.bar /> -> definition
</MyComponent>

MyComponent

{{yield (hash bar=(component "secret-component"))}}

Will be resolved to secret-component path.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #385 (d3af8df) into component-context-info-origin (e150ba7) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@                        Coverage Diff                        @@
##           component-context-info-origin     #385      +/-   ##
=================================================================
+ Coverage                          72.35%   72.63%   +0.27%     
=================================================================
  Files                                 57       57              
  Lines                               4884     4915      +31     
  Branches                             949      959      +10     
=================================================================
+ Hits                                3534     3570      +36     
+ Misses                              1350     1345       -5     
Impacted Files Coverage Δ
src/utils/yield-context-extractor.ts 56.80% <ø> (+1.59%) ⬆️
...uiltin-addons/core/template-completion-provider.ts 93.00% <100.00%> (-0.02%) ⬇️
...uiltin-addons/core/template-definition-provider.ts 78.65% <100.00%> (+2.01%) ⬆️
...ompletion-provider/template-completion-provider.ts 89.74% <100.00%> (+1.17%) ⬆️
src/glimmer-utils.ts 52.73% <100.00%> (+0.23%) ⬆️
src/utils/template-tokens-collector.ts 91.20% <0.00%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e03772...d3af8df. Read the comment docs.

@lifeart lifeart marked this pull request as ready for review April 27, 2022 12:19
@lifeart lifeart merged commit 4618d27 into component-context-info-origin Apr 27, 2022
@lifeart lifeart deleted the go-to-definition-for-yield-scope-path branch April 27, 2022 12:35
lifeart pushed a commit that referenced this pull request Apr 27, 2022
# [2.25.0](v2.24.0...v2.25.0) (2022-04-27)

### Features

* go to definition for yield context components ([#385](#385)) ([4618d27](4618d27))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant