Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Boom post config has issues with non-strings #39

Open
cjgrady opened this issue Jul 7, 2020 · 0 comments
Open

Boom post config has issues with non-strings #39

cjgrady opened this issue Jul 7, 2020 · 0 comments

Comments

@cjgrady
Copy link
Contributor

cjgrady commented Jul 7, 2020

Configuration options that are non-strings are failing. I have updated boom post to cast everything to string but it would be much better if we didn't have to.

This seems to be a change for python 3. We should probably update our Config class in LmCommon.common.config to be a direct subclass of ConfigParser and to override the set method to ensure all values are strings. It may also be beneficial to create our own base config class with the updated set method and have a default ServerConfig class that adds the default configuration files that are used by our current Config class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant