fix(EVMOS): fix name of native evmos coin #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chybisov
requested changes
Oct 25, 2022
| @@ -1135,14 +1135,16 @@ const basicCoins: BasicCoin[] = [ | |||
| // > EVM | |||
| { | |||
| key: CoinKey.EVM, | |||
| name: 'Evmos', | |||
There was a problem hiding this comment.
Maybe we should leave the name as Evmos (https://www.coingecko.com/en/coins/evmos)
There was a problem hiding this comment.
Yeah wasn't to sure either, I took EVMOS because that's what Chainlist showed:
There was a problem hiding this comment.
Also the story requested EVMOS: https://lifi.atlassian.net/browse/LF-1684
| @@ -1135,14 +1135,16 @@ const basicCoins: BasicCoin[] = [ | |||
| // > EVM | |||
| { | |||
| key: CoinKey.EVM, | |||
There was a problem hiding this comment.
Does it also make sense to change the CoinKey.EVM -> CoinKey.EVMOS?
There was a problem hiding this comment.
The story explicitly asked to keep it EVM: https://lifi.atlassian.net/browse/LF-1684
I don't have a strong opinion on it 🤷
chybisov
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.